Re: [PATCH] Phrase search ported to 9.6

Поиск
Список
Период
Сортировка
От Teodor Sigaev
Тема Re: [PATCH] Phrase search ported to 9.6
Дата
Msg-id 56FD5225.6020502@sigaev.ru
обсуждение исходный текст
Ответ на Re: [PATCH] Phrase search ported to 9.6  (Dmitry Ivanov <d.ivanov@postgrespro.ru>)
Ответы Re: [PATCH] Phrase search ported to 9.6  (Dmitry Ivanov <d.ivanov@postgrespro.ru>)
Re: [PATCH] Phrase search ported to 9.6  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Список pgsql-hackers
Looking at patch, I'm inlined to commit it in current commitfest, it looks
workable and too many people desire it. I've did some changes, mostly in
formatting and comments.

Patch makes some user-visible changes:
1 change order for tsquery. Assume, it's acceptable, only a few users store
tsquery in table and have a Btree index. They will need to reindex.
2 less number of parenthesis in tsquery output, and tsquery becomes more readable.

Pls, remove tsquery_setweight from patch because it's not a part of phrase
search and it isn't mentioned in docs. Please, make a separate patch for it.


Dmitry Ivanov wrote:
> Sorry for the delay, I desperately needed some time to finish a bunch of
> dangling tasks.
>
> I've added some new comments and clarified the ones that were obscure.
> Moreover, I felt an urge to recheck most parts of the code since apparently
> nobody (besides myself) has gone so far yet.
>
> On 25.03.16 18:42 MSK, David Steele wrote:
>> Time is short and it's not encouraging that you say there is "still much
> work to be done".
>
> Indeed, I was inaccurate. I am more than interested in the positive outcome.
>
>
>
>

--
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Move PinBuffer and UnpinBuffer to atomics
Следующее
От: Robbie Harwood
Дата:
Сообщение: Re: [PATCH v9] GSSAPI encryption support