Re: Patch: raise default for max_wal_segments to 1GB

On 03/03/2015 02:59 PM, Josh Berkus wrote:
> On 03/03/2015 11:57 AM, Tom Lane wrote:
>> Josh Berkus <josh@agliodbs.com> writes:
>>> Do we want to remove unit comments from all settings which accept
>>> "MB,GB" or "ms,s,min"?  There's more than a few.  I'd be in favor of
>>> this, but seems like (a) it should be universal, and (b) its own patch.
>> Meh.  Doing this strikes me as a serious documentation failure, since it
>> is no longer apparent what happens if you put in a unitless number.
> Well, you know my opinion about documentation in the pg.conf file.
> However, I'm not confident I'm in the majority there.


I think there's a difference between comments about the function of a 
GUC and stating the units it's specified in. It's more than annoying to 
have to go and look that up where it's not stated.

cheers

andrew