Re: Patch: raise default for max_wal_segments to 1GB

On 03/03/2015 11:57 AM, Tom Lane wrote:
> Josh Berkus <josh@agliodbs.com> writes:
>> Do we want to remove unit comments from all settings which accept
>> "MB,GB" or "ms,s,min"?  There's more than a few.  I'd be in favor of
>> this, but seems like (a) it should be universal, and (b) its own patch.
> 
> Meh.  Doing this strikes me as a serious documentation failure, since it
> is no longer apparent what happens if you put in a unitless number.

Well, you know my opinion about documentation in the pg.conf file.
However, I'm not confident I'm in the majority there.

> Now, if we were to change the server so that it *refused* settings that
> didn't have a unit, that argument would become moot.  But I'm not going
> to defend the castle against the villagers who will show up if you do
> that.

No, thanks!

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com