Re: Unifying the spec files?

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/30/2014 11:39 PM, Craig Ringer wrote:
> Still some bugs to fix in the unified package and more testing to
> do but I'm happy with how things are looking. I'll probably need to
> make new mock targets too, of course, but that looks trivial.

I'm down to testing now. Looking good so far.

I removed the addition of -Wl,--as-needed  as configure.in knows to
test for it and add it if it's safe. Forcing it broke RHEL5 builds
because of

    https://sourceware.org/ml/binutils/2005-05/msg00616.html and
    https://bugzilla.redhat.com/show_bug.cgi?id=499837

and was unnecessary anyway.

Updated spec attached with the changes we discussed.

I renamed files source  containing the Pg version to omit it too, so
it's easier to repackage for different versions. So the sources are:

ecpg_config.h
filter-requires-perl-Pg.sh
Makefile.regress
pg_config.h
postgresql-9.4.spec
postgresql-check-db-dir
postgresql.init
postgresql-logging.patch
postgresql.pam
postgresql-perl-rpath.patch
postgresql-prefer-ncurses.patch
postgresql.service
postgresql-setup
README.rpm-dist
rpm-pgsql.patch

with the file contents unchanged, just renamed.

Still got some work to do on making the base name, datadir, etc
configurable, but that's for once the basics are working.

To build, I use mock to produce the srpm, then build the rpms for it.
e.g.:

mock -r fedora-20-x86_64 --buildsrpm \
- --spec rpm/postgresql-x.y.spec --sources rpm/ \
- --resultdir mock-"%(dist)s"-srpm/

for arch in x86_64 i386
do
mock -r fedora-20-$arch \
- --rebuild mock-fedora-20-srpm/postgresql94-9.4beta2-3PGDG.fc20.src.rpm \
- --resultdir mock-"%(dist)s"-"%(target_arch)s"-rpm
done


for the targets in /etc/mock/ . I've used the EPEL targets for RHEL;
strictly I should be targeting stock RHEL + the PGDG RPMs with a new
target file; will try that soon, but it doesn't matter for Pg its self
as it doesn't depend on anything outside RHEL its self.

Now I need to figure out if versioned provides are safe, and look into
making it possible to build variant packages.

Hope you like what you see so far.

- --
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJT2n5UAAoJELBXNkqjr+S2bIYH/j7+7lIRqqRuvg+JCEAu2pYB
VwMPp/b9KdpPBvh1gfedBYTacY5/Tdo+2omdC01QSRbW9Au/YVp4MgN4Kf3DA/dt
NgE/EZPIldfDnhfeYTdN1wO4aBvT2Njn+gBii7Vs462RYCXiVBCLeUl9exmaXlEy
L/QwaloGaBFvheAaSFrwVHc/V76+StG8pYpy2Z/q5OjAL043rzSRxJm9X0QFTJnm
8GeZ+KVDKWGjAjpmu7z1YWU9wSiz6Oatnip1bNnMWwlBhQ256MO3/FhedrrKUGQV
CVVvqmdOQmyu9CeV2tluX6MBETdtrqK0CVRUGc/Gj13W/u3Wd258Oiu+DeILW0M=
=gR/D
-----END PGP SIGNATURE-----