Re: Backup throttling

<div class="moz-cite-prefix">2013-07-31 22:50 keltezéssel, Antonin Houska írta:<br /></div><blockquote
cite="mid:51F9788B.70007@gmail.com"type="cite"><div class="moz-cite-prefix">On 07/31/2013 07:13 AM, Gibheer wrote:
</div><blockquotecite="mid:20130731071336.1491c25b@linse.fritz.box" type="cite"><pre wrap="">Hi,
 

That is a really nice feature.</pre></blockquote> I don't pretend it's my idea, I just coded it. My boss proposed the
featureas such :-)<br /><blockquote cite="mid:20130731071336.1491c25b@linse.fritz.box" type="cite"><pre wrap="">I took
afirst look at your patch and some empty lines you added (e.g. line 60 your patch). Can you remove
 
them?
</pre></blockquote> Sure, will do in the next version.<br /><blockquote
cite="mid:20130731071336.1491c25b@linse.fritz.box"type="cite"><pre wrap="">Why did you move localGetCurrentTimestamp()
intostreamutil.c? Is sys/time.h still needed in receivelog.c after the move?
 
</pre></blockquote> Because both receivelog.c and pg_basebackup.c need it now. I thought I could move
localTimestampDifference()and localTimestampDifferenceExceeds() as well for the sake of consistency (these are actually
utilitiestoo) but I didn't get convinced enough that the feature alone justifies such a change.<br /><br /> As
mentionedin <a href="http://www.postgresql.org/message-id/20130731173624.GX14652@eldon.alvh.no-ip.org"
moz-do-not-send="true">http://www.postgresql.org/message-id/20130731173624.GX14652@eldon.alvh.no-ip.org</a>these
functionsideally shouldn't have separate implementation at all. However the problem is that pg_basebackup is not linked
tothe backend.<br /></blockquote><br /> Have you considered the src/common directory?<br /><br /><blockquote
cite="mid:51F9788B.70007@gmail.com"type="cite"><br /> You're right about sys/time.h, it's included via via
streamutil.h.I'll fix that too.<br /><blockquote cite="mid:20130731071336.1491c25b@linse.fritz.box" type="cite"><pre
wrap="">Iwill try your patch later today to see, if it works.
 

</pre></blockquote> Whenever you have time. Thanks!<br /><br /> // Tony<br /></blockquote><br /> Best regards,<br />
ZoltánBöszörményi<br /><br /><pre class="moz-signature" cols="90">-- 
 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: <a class="moz-txt-link-freetext" href="http://www.postgresql-support.de">http://www.postgresql-support.de</a>
<aclass="moz-txt-link-freetext" href="http://www.postgresql.at/">http://www.postgresql.at/</a>
 
</pre>