Re: Regression tests versus the buildfarm environment

<br /><br /> On 08/12/2010 10:22 AM, Tom Lane wrote: <blockquote cite="mid:13573.1281622963@sss.pgh.pa.us"
type="cite"><prewrap="">Peter Eisentraut <a class="moz-txt-link-rfc2396E"
href="mailto:peter_e@gmx.net"><peter_e@gmx.net></a>writes:
 
</pre><blockquote type="cite"><pre wrap="">On ons, 2010-08-11 at 16:17 -0400, Tom Lane wrote:
</pre><blockquote type="cite"><pre wrap="">We should have the buildfarm configuration such that any one run uses
the same port number for both installed and uninstalled regression
tests.
</pre></blockquote></blockquote><pre wrap="">
</pre><blockquote type="cite"><pre wrap="">I'm getting lost here what the actual requirements are.  The above is
obviously not going to work as a default for pg_regress, because the
port number for an installed test is determined by the user and is
likely to be in the public range, whereas the uninstalled test should
use something from the private range.
</pre></blockquote><pre wrap="">
Certainly, but the buildfarm's "installed" test doesn't try to start on
5432.  It starts on whatever branch_port the buildfarm owner has
specified for that animal and that branch.  It's the owner's
responsibility to make that nonconflicting across the services and
buildfarm critters he has running on a given machine.  What I'm saying
is that *in the buildfarm* we want the "make check" case to also use
this predetermined safe port number.  That has nothing whatever to do
with what is good practice for other cases.
        
</pre></blockquote><br /> Well, I think the steps to do that are:<br /><br /><ul><li>change src/test/GNUmakefile to
providefor a TMP_PORT setting that gets passed to pg_regress<li>change src/tools/msvc/vcregress.pl to
match<li>backpatchthese changes to all live branches<br /><li>change the buildfarm script to use the new
options.</ul><br/> I don't think this should preclude changing the way we calculate the default port for pg_regress,
forthe reasons mentioned upthread.<br /><br /> cheers<br /><br /> andrew<br />