Re: [Fwd: Re: dblink patches for comment]

Tom Lane wrote:
> The quoting logic is still completely the wrong thing :-(.  For one
> thing, quote_literal will try to generate E'' syntax in some cases.
> But more to the point, quote_literal's quoting rules don't match
> what is needed.  A look at libpq's conninfo_parse says that what it
> accepts is single-quoted strings in which backslash quotes the next
> character.  It does not recognize doubled single quotes.  I think
> you will need to whip up a special-purpose quoting subroutine.

OK, I see that. I assume I need to care for encoding issues? If so, do I 
assume server encoding or client encoding?


>> +         return pstrdup(buf->data);
> 
> is a waste of time.  The StringInfo's buffer is already palloc'd.

Thanks -- will fix.

Joe