Re: [PATCHES] snprintf() argument reordering not working

Bruce Momjian wrote:

>>Was the last patch you sent in ready for application, or are you still
>>fooling with it?
>>    
>>
>
>He is still working on it.  It did not handle all *printf functions, as
>he mentioned, and he might have other changes.
>
>  
>

Yeah.

The good news: the new pg_*printf does the right thing for the %m$ 
parameters in the Turkish locale.

The bad news: if we aren't compiling with NLS enabled, having those 
entries in exports.txt makes the libpq build blow up. So either we need 
to use pg_*printf unconditionally on Windows, or we need a little 
Makefile + sed magic to strip those entries out of exports.txt when it 
is used, if we're not doing NLS, or something of that kind.

Question: do the entries in exports.txt have to be numbered 
consecutively, or just uniquely?

With luck I can probably wrap this up today for the 8.1 stable branch - 
it would be nice if the new release actually did NLS right.

cheers

andrew