Re: [PATCHES] snprintf() argument reordering not working

Andrew Dunstan <andrew@dunslane.net> writes:
> The bad news: if we aren't compiling with NLS enabled, having those 
> entries in exports.txt makes the libpq build blow up. So either we need 
> to use pg_*printf unconditionally on Windows, or we need a little 
> Makefile + sed magic to strip those entries out of exports.txt when it 
> is used, if we're not doing NLS, or something of that kind.

I think it's a bad idea for exports.txt not to be the same in all
builds.  So yeah, if we export these names at all then it has to be
unconditional.

What about Plan B?  Per Bruce's comment, it should really only be ecpg
that needs an extra copy of snprintf.o, and it's not like ecpg doesn't
already pull in various port/ files for itself.
        regards, tom lane