Re: DTrace probes patch

Hi,

On Thu, Dec 18, 2008 at 4:49 AM, Robert Lor <Robert.Lor@sun.com> wrote:
> Alvaro Herrera wrote:
>>
>> But there are 5 callers of XLogWrite ... why aren't the other ones being
>> tracked too?
>>
>>
>
> This probe originally came from Simon, so it can't possibly be wrong :-)
>
> My understanding is that we only want to track the XLogWrite when advancing
> to the next buffer page, and if there is unwritten data in the new buffer
> page, that indicates no more empty WAL buffer pages available, but I may be
> wrong. I did some tests by adjusting wal_buffers, and I could observe this
> behavior, more calls to XLogWrite with smaller wal_buffers.

I understood your intention. But, I think that its function name is somewhat
confusing.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center