On 12/15/17 14:10, Robert Haas wrote:
>> There is an argument for having a big array versus the switch/case
>> approach. But most existing code around object addresses uses the
>> switch/case approach, so it's better to align it that way, I think.
>> It's weird to have to maintain two different styles.
> Eh, really? What about the two big arrays at the top of objectaddress.c?
They are not indexed by object type. I can't find any existing array or
other structure that fits into what this patch is doing (other than the
one this patch is removing).
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services