Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'

Hi,

On 2019-08-22 10:47:39 +0900, Michael Paquier wrote:
> On Wed, Aug 21, 2019 at 10:34:49AM -0400, Alvaro Herrera wrote:
> > Ah, yes, that's right -- my system's open(3p) manpage says:
> > 
> >        The  open()  function  shall return a file descriptor for the named file
> >        that is the lowest file descriptor not currently open for that process.
> 
> Ah, well.  In this case, what about that?
> ("too many jobs for this platform's select() -- try %d", i-1)

I don't think the - 1 bit is likely to be helpful, as it's too likely to
be inaccurate.

> I don't think that it is a good idea to use the option name -j/--jobs
> directly in the error string as scripts_parallel.c should not have any
> knowledge of how the option layer is in the tools using its APIs.

This isn't a particularly general API - it's in
src/bin/scripts/scripts_parallel.h. So I think a better error message is
more than worth the slight decrease in generality.

Greetings,

Andres Freund