Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'
Дата
Msg-id 20190822014739.GB1683@paquier.xyz
обсуждение исходный текст
Ответ на Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Ответы Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'  (Andres Freund <andres@anarazel.de>)
Список pgsql-bugs
On Wed, Aug 21, 2019 at 10:34:49AM -0400, Alvaro Herrera wrote:
> Ah, yes, that's right -- my system's open(3p) manpage says:
>
>        The  open()  function  shall return a file descriptor for the named file
>        that is the lowest file descriptor not currently open for that process.

Ah, well.  In this case, what about that?
("too many jobs for this platform's select() -- try %d", i-1)

I don't think that it is a good idea to use the option name -j/--jobs
directly in the error string as scripts_parallel.c should not have any
knowledge of how the option layer is in the tools using its APIs.
Attached is an updated patch, with refined comments.
--
Michael

Вложения

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'
Следующее
От: Sandeep Thakkar
Дата:
Сообщение: Re: Postgres 11.5.1 failed installation