On Sat, Jul 14, 2018 at 03:47:38PM +0700, John Naylor wrote:
> I hope you don't mind, but since it might be tedious to piece together
> the addenda I left behind in this thread, I thought it might be useful
> to update Joe's patch. The attached was rebased over the new
> regression test, passes the pg_upgrade test, and has a draft commit
> message.
The test added by ecd6b434 is very helpful. Looking at the patch, this
seems sane to me. pg_upgrade run with different past versions is
proving to pass properly, and we don't want to have toast tables for
large object catalogs. It is nice that you took care of putting things
in a consistent order in IsSharedRelation().
--
Michael