Re: [HACKERS] brin_summarize_new_values error checking
От | Alvaro Herrera |
---|---|
Тема | Re: [HACKERS] brin_summarize_new_values error checking |
Дата | |
Msg-id | 20170923111630.rrl3uuy6d4hmcopo@alvherre.pgsql обсуждение исходный текст |
Ответ на | Re: brin_summarize_new_values error checking (Fujii Masao <masao.fujii@gmail.com>) |
Список | pgsql-hackers |
Fujii Masao wrote: > On Wed, Jan 27, 2016 at 11:56 AM, Fujii Masao <masao.fujii@gmail.com> wrote: > > On Mon, Jan 25, 2016 at 4:03 PM, Jeff Janes <jeff.janes@gmail.com> wrote: > >> In reviewing one of my patches[1], Fujii-san has pointed out that I > >> didn't include checks for being in recovery, or for working on another > >> backend's temporary index. > >> > >> I think that brin_summarize_new_values in 9.5.0 commits those same > >> sins. In its case, I don't think those are critical, as they just > >> result in getting less specific error messages that one might hope > >> for, rather than something worse like a panic. > >> > >> But still, we might want to address them. > > > > Agreed to add those checks. > > Attached patch does this. Uh, I just realized you never applied this patch ... Will you do so now? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
В списке pgsql-hackers по дате отправления: