Small patch: Change calling convention for ShmemInitHash (and fix possible bug)

Поиск
Список
Период
Сортировка
От Aleksander Alekseev
Тема Small patch: Change calling convention for ShmemInitHash (and fix possible bug)
Дата
Msg-id 20160324165045.1b4eb1a0@fujitsu
обсуждение исходный текст
Ответы Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Hello

I would like to continue discussion regarding changing calling
convention for ShmemInitHash procedure:

http://www.postgresql.org/message-id/CA+TgmoZm=Uowt8a_XaSfooGwufeeLJ861NTADiCEOpyFehV8Wg@mail.gmail.com

Currently this procedure has two arguments --- init_size and max_size.
But since shared hash tables have fixed size there is little sense to
pass two arguments. In fact currently ShmemInitHash is always called
with init_size == max_size with only one exception, InitLocks procedure
(see lock.c), which I believe is actually a bug.

Patch is attached.

What do you think?

--
Best regards,
Aleksander Alekseev
http://eax.me/

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Masahiko Sawada
Дата:
Сообщение: Re: Support for N synchronous standby servers - take 2
Следующее
От: Konstantin Knizhnik
Дата:
Сообщение: avg,first,last,median in one query