Re: tests for client programs

On Thu, Jun 05, 2014 at 10:57:03AM +0200, Andres Freund wrote:
> On 2014-06-04 20:40:40 -0400, Peter Eisentraut wrote:
> > On Wed, 2014-05-07 at 03:08 +0200, Andres Freund wrote:
> > > > As an additional issue it currently doesn't seem to work in VPATH
> > > > builds. That's imo a must fix.
> > > 
> > > A "cd $(srcdir) && .." in prove_installcheck and prove_check seems to do
> > > the trick.
> > 
> > Here is my proposed patch for this.
> 
> Except that I'd rather named CURDIR REGRESSDIR or such this looks sane.
> 
> >  sub tempdir
> >  {
> > -    return File::Temp::tempdir('testXXXX', DIR => cwd(), CLEANUP => 1);
> > +    return File::Temp::tempdir('testXXXX', DIR => $ENV{CURDIR} || cwd(), CLEANUP => 1);
> >  }

I recommend "TMPDIR => 1" instead of setting DIR.  This temporary directory is
used for Unix sockets, so path length limitations will be a problem:

http://www.postgresql.org/message-id/20140329172224.GA170273@tornado.leadboat.com

-- 
Noah Misch
EnterpriseDB                                 http://www.enterprisedb.com