Re: tests for client programs

On 2014-06-04 20:40:40 -0400, Peter Eisentraut wrote:
> On Wed, 2014-05-07 at 03:08 +0200, Andres Freund wrote:
> > > As an additional issue it currently doesn't seem to work in VPATH
> > > builds. That's imo a must fix.
> > 
> > A "cd $(srcdir) && .." in prove_installcheck and prove_check seems to do
> > the trick.
> 
> Here is my proposed patch for this.

Except that I'd rather named CURDIR REGRESSDIR or such this looks sane.

>  sub tempdir
>  {
> -    return File::Temp::tempdir('testXXXX', DIR => cwd(), CLEANUP => 1);
> +    return File::Temp::tempdir('testXXXX', DIR => $ENV{CURDIR} || cwd(), CLEANUP => 1);
>  }

Unrelated to this, but for me cleanup doesn't always seem to succeed?
Also could we name the directories tmp_testXXXX akin to tmp_check?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services