Re: Hot standby 9.2.6 -> 9.2.6 PANIC: WAL contains references to invalid pages

On 2014-01-13 23:29:59 +0200, Heikki Linnakangas wrote:
> On 01/13/2014 11:02 PM, Andres Freund wrote:
> >Now, you could argue that that shouldn't be the case because we're only
> >entering that codepath once STANDBY_SNAPSHOT_READY and you might be
> >right...
>
> I don't think that saves us. standbyMode can be STANDBY_SNAPSHOT_READY,
> before we reach consistency. Adding a check for reachedConsistency, though,
> ought to fix it.

Maybe we should just put LocalHotStandbyActive into xlog_internal.h?
That'd be enough for the startup process. Or alternatively add a check
for EnableHotStandby into HotStandbyActive() so we don't take the
spinlock if it's not enabled?

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services