Re: [PATCH]-hash index improving

Kenneth Marshall escribió:
> On Thu, Jul 17, 2008 at 12:42:39PM -0400, Alvaro Herrera wrote:

> > I think having the HASHVALUE_ONLY define is not a good idea -- it just
> > makes the patch harder to read.  I suggest just removing the old code
> > and putting the new code in place.  (That's why we have revision
> > control.)
> > 
> One thing it helps is building an old version and a new version
> for comparative testing. Otherwise, you could end up with an apples-to-
> oranges comparison. I certainly think that the final patch should not
> have it, but it is useful now for testing and comparisons.

For this purpose I think it would be easier to have a separate tree with
the patch, and one without it.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support