Re: Improve shutdown during online backup, take 4

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: Improve shutdown during online backup, take 4
Дата
Msg-id 20080423154540.64dd7862@mha-laptop
обсуждение исходный текст
Ответ на Improve shutdown during online backup, take 2  ("Albe Laurenz" <laurenz.albe@wien.gv.at>)
Ответы Re: Improve shutdown during online backup, take 4  (Alvaro Herrera <alvherre@commandprompt.com>)
Список pgsql-patches
Albe Laurenz wrote:
> Magnus Hagander wrote:
> > This doesn't look like our normal coding standards, and should
> > probably be changed:
> > +     if (0 != stat(BACKUP_LABEL_FILE, &stat_buf))
> >
> > (there's a number of similar places)
>
> I see. Lacking guidelines, I now copied how stat(2) is used in
> other parts of the code.

Applied with some minor changes to the error messages to make them
closer to our guidelines. (With my track record, it's not entirely
unlikely that someone will fix them further though :-P)

//Magnus

В списке pgsql-patches по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: Snapshot management, final
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: temporal version of generate_series()