Re: [HACKERS] Darwin compile fixes

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Attached is a cleaned up version of the patch (without wrapping).  The
> > change is to use "$(CXX) $(CFLAGS)" instead of $(COMPILER).  Does this
> > change break OS/X?
>
> Since our configure doesn't define CXX, I'm having a hard time imagining
> how it could fail to break it.
>
> If we *did* define CXX, it would presumably point to g++, which would
> also break things since our source code is not C++ clean.
>
> Even more to the point, Darwin isn't broken now --- at least it works
> fine on the powerbook I'm typing this on, and on the several OSX
> machines in the buildfarm.
>
> I would like to know what this patch is alleged to fix before even
> considering applying it.

Yea, I see in Makefile.shlib:

    COMPILER = $(CC) $(CFLAGS)

so the code is really changing $CC to $CXX.  The big question is why
that change is required.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073