Re: Patch for disaster recovery

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > + /* This is to be used only for disaster recovery and requires serious analysis. */
> > + #ifdef MAKE_ALL_TUPLES_VISIBLE
> > +     return true;
> > + #endif
>
> If this requires serious analysis, why did you install the patch without
> any public discussion?
>
> I cannot imagine any situation where this wouldn't break things beyond
> belief, and so I request that you revert the patch until you've provided
> a real example in which it would help.

We regularly have people on IRC who delete data and then want to recover
it.  By having the define it makes it easier for us to help them without
them having to add actual C code.

Does that make sense?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073