Re: Heading to final release

Tom Lane wrote:
> Rod Taylor <rbt@rbt.ca> writes:
> > I vote to disable the checks for pg_restore if the dumpfile has a check
> > added to ensure it's the same file that was dumped (an MD5 in the
> > header) and it is a full database restore.
> > Individual table restores should require the check.
> 
> It is not our business to be making such decisions for the DBA.  If
> we're going to provide this at all, it should be in the form of a knob
> the DBA can tweak if *he* thinks it's safe to omit the check.

We could allow the dba to _enable_ the check if they want it, of course.
Basically, default it to checks off rather than on.  However, there is
no logic that could distinguish a hand-created dump from one we dumped. 
This is another area where a guc variable identifing a dump would help.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073