Re: location of Unix socket
От | Bruce Momjian |
---|---|
Тема | Re: location of Unix socket |
Дата | |
Msg-id | 200011272106.QAA22218@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: location of Unix socket (Tom Lane <tgl@sss.pgh.pa.us>) |
Список | pgsql-hackers |
> Bruce Momjian <pgman@candle.pha.pa.us> writes: > > Am I handling this properly? I hate to be dragging around the unix > > socket directory name in pghost for too long and hate to be propogating > > the slash test throughout the code. > > It's probably cleanest to do that the way you are doing it. However, > one could argue we should make PQhost() return > pghost ? pghost : pgunixsocket > which'd make the external behavior compatible with the way one specifies > the connection. > > Basically, the idea was to *not* have a distinct unixsocket spec > anywhere in libpq's external API, so that existing apps wouldn't need > a rewrite to support this feature. Keeping unixsocket separate inside > the library is a good idea, but it's independent of the API. Done. New code: return conn->pghost ? conn->pghost : conn->pgunixsocket; -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
В списке pgsql-hackers по дате отправления: