Re: [HACKERS] Re: [SQL] Column name's length
От | Bruce Momjian |
---|---|
Тема | Re: [HACKERS] Re: [SQL] Column name's length |
Дата | |
Msg-id | 199906011549.LAA13528@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: [HACKERS] Re: [SQL] Column name's length (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: [HACKERS] Re: [SQL] Column name's length
Re: [HACKERS] Re: [SQL] Column name's length |
Список | pgsql-hackers |
> Bruce Momjian <maillist@candle.pha.pa.us> writes: > >> It'd probably be worthwhile to move NAMEDATALEN to config.h and make the > >> other two symbols be computed off NAMEDATALEN. Any objections if I > >> sneak that change into 6.5, or is it too close to being a "new feature"? > > > Don't they have to be visible to outside apps, so it is in postgres_ext.h? > > Good point --- I was thinking that postgres_ext.h includes config.h, > but I see it ain't so. You're right, those definitions must stay where > they are. > > Still, I wonder why OIDNAMELEN isn't just defined as > (NAMEDATALEN+sizeof(Oid)) rather than putting a comment to that effect. > I will check the uses and see if that is a safe change or not. Yes, probably should be changed. The old code did some fancy sed with it, so maybe it had to be a real number back then, or perhaps initdb pulls it from the file. Not sure. -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
В списке pgsql-hackers по дате отправления: