Re: buildfarm breakage

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: buildfarm breakage
Дата
Msg-id 16389.1265731901@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: buildfarm breakage  (Magnus Hagander <magnus@hagander.net>)
Ответы Re: buildfarm breakage  (Magnus Hagander <magnus@hagander.net>)
Список pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> Here's a patch that "fixes" this. I put it locally for the radius
> authentication for now, since we don't use this anywhere else. Should
> we put this in /port/ somewhere, or is this good for now?

How about dropping it in src/backend/port/win32/mingwcompat.c ?

The advantage of putting it in src/port/ is that it would possibly
help client-side code sometime in future.  But what seems more likely
to happen is that the mingw people will fix their oversight, and
then we'd be risking link conflicts, which will be harder to fix on
the client side.  So I'm inclined to not go there as long as we
don't actually need it on client side.  But putting mingw hacks
in a mingw-specific place seems a good idea.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: bugfix - VIP: variadic function ignore strict flag
Следующее
От: Tom Lane
Дата:
Сообщение: Re: bugfix - VIP: variadic function ignore strict flag