Re: pgindent messing up "translator: " comments
От | Alvaro Herrera |
---|---|
Тема | Re: pgindent messing up "translator: " comments |
Дата | |
Msg-id | 1315251261-sup-8182@alvh.no-ip.org обсуждение исходный текст |
Ответ на | pgindent messing up "translator: " comments (Alvaro Herrera <alvherre@alvh.no-ip.org>) |
Список | pgsql-hackers |
Excerpts from Alvaro Herrera's message of lun sep 05 16:21:38 -0300 2011: > I just noticed that this comment got reindented by pgindent > (xlog.c, line 3226 in REL9_1_STABLE): > /* > * translator: First %s represents a recovery.conf parameter name like > * "recovery_end_command", and the 2nd is the value of that parameter. > */ > ereport((signaled && failOnSignal) ? FATAL : WARNING, > (errmsg("%s \"%s\": return code %d", commandName, > command, rc))); Actually, after I looked into Git history it turns out that this comment was introduced in this way; it wasn't pgindent's fault. I checked a couple of diffs from pgindent runs, and I found no "translator:" comment reindented destructively. Still, it seems possible that it could happen someday. I will fix this one occurence. -- Álvaro Herrera <alvherre@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support
В списке pgsql-hackers по дате отправления: