pgindent messing up "translator: " comments
От | Alvaro Herrera |
---|---|
Тема | pgindent messing up "translator: " comments |
Дата | |
Msg-id | 1315250268-sup-2083@alvh.no-ip.org обсуждение исходный текст |
Ответы |
Re: pgindent messing up "translator: " comments
Re: pgindent messing up "translator: " comments Re: pgindent messing up "translator: " comments |
Список | pgsql-hackers |
I just noticed that this comment got reindented by pgindent (xlog.c, line 3226 in REL9_1_STABLE): /* * translator: First %s represents a recovery.conf parameter name like * "recovery_end_command", and the 2nd is the value of that parameter. */ ereport((signaled && failOnSignal) ? FATAL: WARNING, (errmsg("%s \"%s\": return code %d", commandName, command, rc))); Sure enough, the resulting POT entry does not have the necessary comment: #: /pgsql/source/REL9_1_STABLE/src/backend/access/transam/xlog.c:3230 #, c-format msgid "%s \"%s\": return code %d" msgstr "" I think the proper fix would be to use the /*---- trick, such as in postmaster.c: /*------ translator: %s is a noun phrase describing a child process, such as "server process" */ (errmsg("%s (PID %d) exited with exit code %d", procname, pid, WEXITSTATUS(exitstatus)))); It seems to me that we should alert if pgindent does anything to a comment line containing "translator:". -- Álvaro Herrera <alvherre@alvh.no-ip.org>
В списке pgsql-hackers по дате отправления: