Обсуждение: Fix typo in code comment

Поиск
Список
Период
Сортировка

Fix typo in code comment

От
"kelan"
Дата:
Hi hickers,
I fixed a comment error in the `WaitForParallelWorkersToFinish` function. The original comment was "In that case, or latch should have been set as well...",  where I think "or" is a typo and it should be "our".

--
Best regards,
Ke Lan
Email:ke_lan1@qq.com









Вложения

Re: Fix typo in code comment

От
Chao Li
Дата:

> On Dec 31, 2025, at 09:10, kelan <ke_lan1@qq.com> wrote:
>
> Hi hickers,
> I fixed a comment error in the `WaitForParallelWorkersToFinish` function. The original comment was "In that case, or
latchshould have been set as well...",  where I think "or" is a typo and it should be "our". 
>
> --
> Best regards,
> Ke Lan
> Email:ke_lan1@qq.com
>
> <v1-0001-correct-typos-in-the-code-comments.patch>

Looking at the context, “or” doesn’t make sense here. Both “the” and “our” would work grammatically, and given the
intentof the comment, “our” seems the most likely original wording. 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







Re: Fix typo in code comment

От
Masahiko Sawada
Дата:
On Sun, Jan 4, 2026 at 1:24 AM Chao Li <li.evan.chao@gmail.com> wrote:
>
>
>
> > On Dec 31, 2025, at 09:10, kelan <ke_lan1@qq.com> wrote:
> >
> > Hi hickers,
> > I fixed a comment error in the `WaitForParallelWorkersToFinish` function. The original comment was "In that case,
orlatch should have been set as well...",  where I think "or" is a typo and it should be "our". 
> >
> > --
> > Best regards,
> > Ke Lan
> > Email:ke_lan1@qq.com
> >
> > <v1-0001-correct-typos-in-the-code-comments.patch>
>
> Looking at the context, “or” doesn’t make sense here. Both “the” and “our” would work grammatically, and given the
intentof the comment, “our” seems the most likely original wording. 
>

I agree that it's a typo. I've just pushed the patch. Thank you!

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com