Обсуждение: Fix incorrect buffer lock description in pg_visibility comment

Поиск
Список
Период
Сортировка

Fix incorrect buffer lock description in pg_visibility comment

От
Chao Li
Дата:
Hi Hackers,

While reviewing the patch [1], though I couldn’t raise a comment for it, I noticed a comment error in the file pg_visibility.c, where a buffer lock is held in shared mode but the code comment mentioned exclusive mode. I am filing a small patch to correct the comment.

I only changed "exclusively" to "shared", the format changed was done by pgindent.


Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/




Вложения

Re: Fix incorrect buffer lock description in pg_visibility comment

От
Masahiko Sawada
Дата:
Hi,

On Tue, Dec 23, 2025 at 6:18 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
> Hi Hackers,
>
> While reviewing the patch [1], though I couldn’t raise a comment for it, I noticed a comment error in the file
pg_visibility.c,where a buffer lock is held in shared mode but the code comment mentioned exclusive mode. I am filing a
smallpatch to correct the comment. 
>
> I only changed "exclusively" to "shared", the format changed was done by pgindent.

Yeah, it seems like a typo since the first commit of pg_visiblity,
e472ce9624e0. I think we can backpatch it to all supported versions.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com