Обсуждение: Postgres Patch Review Workshop: January 2026

Hello Hackers,

I'm organizing a Postgres Patch Review Workshop as a way to help new
Postgres contributors get experience and tips reviewing patches. We've
had four successful workshops so far, for the commitfests in March,
July, September, and December. This will be for January 2026.

These workshops have helped me finish more reviews than usual, and I've
personally learned a lot. Reviewing patches is hard, but having a
partner and a time commitment makes it easier.

The plan is to form teams of 2-3 people, who will pick a patch and
review it. Then we'll meet in a larger group, and teams will spend
15-30 minutes presenting the patch and their feedback. Typically we
have enough patches to schedule 2 meetings, with 2 or 3 presentations
per meeting. Several veteran committers have also attended and given
feedback on people's reviews. Thank you especially to Robert Haas,
Andrey Borodin, and Jacob Champion!

The January commitfest is starting soon, so I'd like to hear from
people who want to participate. I'll build a list and play matchmaker
(but if you already know who you want to work with, let me know).
Please use this link to sign up:

https://forms.gle/ycf5g7VsJRXgkS2r5

If you are a longtime Postgres contributor and would be willing to
attend the final meeting to offer advice about the reviews, I'd love to
get your help too! Please use that link to sign up.

We also have a Discord channel, #patch-review-workshop, on the
PostgreSQL Hacking server:
https://discord.com/channels/1258108670710124574/1342147702804447354

Later, once you've sent your review to pgsql-hackers, send me a link.
Then we'll schedule the larger meeting(s), based on how many people
completed the "assignment". I expect these will happen in early
February.

I don't want to reinvent anything from the commitfest app. My goal is
just to help people find partners and then present their feedback.
Please add yourself as a reviewer in the commitfest app, so that people
don't all review the same thing!

Here are some links about reviewing patches:

- https://wiki.postgresql.org/wiki/Reviewing_a_Patch
- Reviewing Postgres Patches for Fun and Profit, David Steele:
  https://www.youtube.com/watch?v=FzNXFJ2-r0s

Yours,

-- 
Paul              ~{:-)
pj@illuminatedcomputing.com

On Mon, Dec 22, 2025 at 1:52 PM Paul A Jungwirth
<pj@illuminatedcomputing.com> wrote:
>
> Hello Hackers,
>
> I'm organizing a Postgres Patch Review Workshop as a way to help new
> Postgres contributors get experience and tips reviewing patches. We've
> had four successful workshops so far, for the commitfests in March,
> July, September, and December. This will be for January 2026.
>

I have been a little disconnected from -hackers for some time now, I
didn't know
about this but seems a terrific idea.

Do you have a plan of "when in January" these meetings will happen? or
is it more like
"this is your assignment" make arrangements with your review team?


--
Jaime Casanova
SYSTEMGUARDS

On Mon, Dec 22, 2025 at 3:49 PM Jaime Casanova
<jcasanov@systemguards.com.ec> wrote:
>
> Do you have a plan of "when in January" these meetings will happen? or
> is it more like
> "this is your assignment" make arrangements with your review team?

Hi Jaime,

I like to give people about a week for signups, then I pair people off
based mostly on timezone. Sometimes people ask for a specific partner.
Sometimes I make a group of 3 to make things work.

It is up to you and your partner which patch to review, when to meet,
etc. I think my own partners and I have almost always just
communicated via email.

Ideally by the end of the commitfest people have shared links to their
reviews. Then I'll propose some meeting times, give people some more
time to respond, and schedule meetings to discuss the reviews. (It's
always wound up being two meetings of 2-3 reviews each.)

The last couple sessions we have been a little late with reviews, but
I'd like to start getting back on track there.

I hope this helps. I replied on the list in case others were wondering
the same things. Let me know if you have any more questions!

Yours,

--
Paul              ~{:-)
pj@illuminatedcomputing.com