Обсуждение: [PATCH] Little refactoring of portalcmds.c

Поиск
Список
Период
Сортировка

[PATCH] Little refactoring of portalcmds.c

От
Aleksander Alekseev
Дата:
Hi,

The proposed patch places some repetitive code in a helper function.
The value of this change is arguably not that high but it makes the
code a bit neater IMO.

-- 
Best regards,
Aleksander Alekseev
Вложения

Re: [PATCH] Little refactoring of portalcmds.c

От
Quan Zongliang
Дата:

On 10/8/25 10:02 PM, Aleksander Alekseev wrote:
> Hi,
> 
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO.
> 

It also reduces the ease of reading the code.
Just add a function for a single if statement. I don't think it's necessary.

Regards,
Quan Zongliang

Re: [PATCH] Little refactoring of portalcmds.c

От
wenhui qiu
Дата:
Hi Aleksander Alekseev
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO. 
I  agree with your suggestion to refactor the duplicated code into a function.

Thanks 

On Mon, Oct 27, 2025 at 2:03 PM Quan Zongliang <quanzongliang@yeah.net> wrote:


On 10/8/25 10:02 PM, Aleksander Alekseev wrote:
> Hi,
>
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO.
>

It also reduces the ease of reading the code.
Just add a function for a single if statement. I don't think it's necessary.

Regards,
Quan Zongliang