Обсуждение: PgBouncer 1.24.0 - New upstream version
Hi All, PgBouncer 1.24.0 was recently released [0]. I've updated the Debian package with this new version but I am running into some issues with the autopkgtests. The autopkgtests passes on Salsa's CI but is failing on my both my local system and jengus [1]. On my local system, the test fails to create a new regress cluster because port 5432 is already in use. I recently switched my sbuild configuration from schroot to unshare. It looks like the unshare backend doesn't create a new network namespace when running the autopkgtests. If I stop the main postgres cluster on my machine before running sbuild/autopkgtest, then the test passes. After reviewing the autopkgtest docs [2] and the test script, I think we might need to add isolation-container to the test's restrictions. On my local system, this causes the test to be skipped since the unshare backend doesn't provide this capability. I will try to look in to this some more in the next few days, but I wanted to check and see if anyone had run into similar issues with building and testing other packages. -- Bradford [0]: https://github.com/pgbouncer/pgbouncer/releases/tag/pgbouncer_1_24_0 [1]: https://jengus.postgresql.org/job/pgbouncer-binaries/101/architecture=amd64,distribution=sid/ [2]: https://people.debian.org/~eriberto/README.package-tests.html
Hey Bradford,
I haven't run into that issue myself but will poke at it today and see if I can reproduce it.
Unrelated to autopkgtest, I noticed in October that during debbuild the package does not run the main pytest suite for pgbouncer? Is that intentional? It appears that before the tests were rewritten in python that the package ran the shell-based suite properly.
I submitted a patch that should be able to be incorporated as-is: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1085109
On Sat, Jan 11, 2025 at 2:46 AM Bradford Boyle <bradford.d.boyle@gmail.com> wrote:
Hi All,
PgBouncer 1.24.0 was recently released [0]. I've updated the Debian
package with this new version but I am running into some issues with the
autopkgtests. The autopkgtests passes on Salsa's CI but is failing on
my both my local system and jengus [1].
On my local system, the test fails to create a new regress cluster
because port 5432 is already in use. I recently switched my sbuild
configuration from schroot to unshare. It looks like the unshare backend
doesn't create a new network namespace when running the autopkgtests.
If I stop the main postgres cluster on my machine before running
sbuild/autopkgtest, then the test passes. After reviewing the
autopkgtest docs [2] and the test script, I think we might need to add
isolation-container to the test's restrictions. On my local system, this
causes the test to be skipped since the unshare backend doesn't provide
this capability.
I will try to look in to this some more in the next few days, but I
wanted to check and see if anyone had run into similar issues with
building and testing other packages.
-- Bradford
[0]: https://github.com/pgbouncer/pgbouncer/releases/tag/pgbouncer_1_24_0
[1]: https://jengus.postgresql.org/job/pgbouncer-binaries/101/architecture=amd64,distribution=sid/
[2]: https://people.debian.org/~eriberto/README.package-tests.html
Brian Cosgrove
Hi Brian, On Sun, Jan 12, 2025 at 4:47 AM Brian Cosgrove <cosgroveb@gmail.com> wrote: > > Unrelated to autopkgtest, I noticed in October that during debbuild > the package does not run the main pytest suite for pgbouncer? Is that > intentional? It appears that before the tests were rewritten in python > that the package ran the shell-based suite properly. Looking at the history for d/rules, I think disabling the main test suite during the build was intended to be a temporary fix for a missing file in the upstream source archive [0],[1]. It looks like the tests weren't re-enabled when the issue was fixed upstream. > I submitted a patch that should be able to be incorporated as-is: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1085109 I've applied your patch to the package and pushed the changes to Salsa. I did have to drop the b-d on python3-contextlib2 since this package is not available (and not needed) in unstable. I also had to add tzdata-legacy in order for the tests to pass. We'll probably need to add some tweaks for the pgdg packages to build on older distributions. [0]: https://salsa.debian.org/postgresql/pgbouncer/-/commit/74f05a0#8756c63497c8dc39f7773438edf53b220c773f67_22_25 [1]: https://github.com/pgbouncer/pgbouncer/issues/431
Hi Brian, I was looking at the package for pgBouncer 1.24.0 again today and it looks like the tests are failing [0]. After reading through the logs, it looks like psycopg in testing and unstable was updated to 3.2.4 this past Friday. I am able to reproduce the test failures in dev environment by updating the version in requirements.txt. Should we disable the main test suite for now to unblock the upload of 1.24.0? Regards, --Bradford [0]: https://salsa.debian.org/postgresql/pgbouncer/-/jobs/6962351
Yes, please do. A Postgres client package (psycopg) update causing failing integration tests seems highly unlikely to be a genuine issue for the pgbouncer.
I also reproduced locally the failures you're seeing on Salsa. I notice that there are relevant changes in psycopg 3.2.4 and I think that there are some assertions needing updates in the upstream project.
I'll file an issue with pgbouncer but for now please unblock the upload.
On Mon, Jan 20, 2025 at 10:42 PM Bradford Boyle <bradford.d.boyle@gmail.com> wrote:
Hi Brian,
I was looking at the package for pgBouncer 1.24.0 again today and it
looks like the tests are failing [0]. After reading through the logs, it
looks like psycopg in testing and unstable was updated to 3.2.4 this
past Friday. I am able to reproduce the test failures in dev environment
by updating the version in requirements.txt. Should we disable the main
test suite for now to unblock the upload of 1.24.0?
Regards,
--Bradford
[0]: https://salsa.debian.org/postgresql/pgbouncer/-/jobs/6962351
Brian Cosgrove
I think this note in the psycopg 3.2.4 news is what we're seeing in the pgbouncer tests: https://github.com/psycopg/psycopg/compare/3.2.3...3.2.4#diff-87f7a7bb7fe8dbed76e16b67b87f27bda7b779b56e7d93ed3350d77ee4a3f217R20-R23
On Mon, Jan 20, 2025 at 11:25 PM Brian Cosgrove <cosgroveb@gmail.com> wrote:
Yes, please do. A Postgres client package (psycopg) update causing failing integration tests seems highly unlikely to be a genuine issue for the pgbouncer.I also reproduced locally the failures you're seeing on Salsa. I notice that there are relevant changes in psycopg 3.2.4 and I think that there are some assertions needing updates in the upstream project.I'll file an issue with pgbouncer but for now please unblock the upload.On Mon, Jan 20, 2025 at 10:42 PM Bradford Boyle <bradford.d.boyle@gmail.com> wrote:Hi Brian,
I was looking at the package for pgBouncer 1.24.0 again today and it
looks like the tests are failing [0]. After reading through the logs, it
looks like psycopg in testing and unstable was updated to 3.2.4 this
past Friday. I am able to reproduce the test failures in dev environment
by updating the version in requirements.txt. Should we disable the main
test suite for now to unblock the upload of 1.24.0?
Regards,
--Bradford
[0]: https://salsa.debian.org/postgresql/pgbouncer/-/jobs/6962351--Brian Cosgrove
Brian Cosgrove
Ah, funny, we (pgbouncer) just started pinning this in requirements.txt because of this failure: https://github.com/pgbouncer/pgbouncer/commit/0cf59fadc0671a7363afa51086631b87a26893dc
On Mon, Jan 20, 2025 at 11:38 PM Brian Cosgrove <cosgroveb@gmail.com> wrote:
I think this note in the psycopg 3.2.4 news is what we're seeing in the pgbouncer tests: https://github.com/psycopg/psycopg/compare/3.2.3...3.2.4#diff-87f7a7bb7fe8dbed76e16b67b87f27bda7b779b56e7d93ed3350d77ee4a3f217R20-R23On Mon, Jan 20, 2025 at 11:25 PM Brian Cosgrove <cosgroveb@gmail.com> wrote:Yes, please do. A Postgres client package (psycopg) update causing failing integration tests seems highly unlikely to be a genuine issue for the pgbouncer.I also reproduced locally the failures you're seeing on Salsa. I notice that there are relevant changes in psycopg 3.2.4 and I think that there are some assertions needing updates in the upstream project.I'll file an issue with pgbouncer but for now please unblock the upload.On Mon, Jan 20, 2025 at 10:42 PM Bradford Boyle <bradford.d.boyle@gmail.com> wrote:Hi Brian,
I was looking at the package for pgBouncer 1.24.0 again today and it
looks like the tests are failing [0]. After reading through the logs, it
looks like psycopg in testing and unstable was updated to 3.2.4 this
past Friday. I am able to reproduce the test failures in dev environment
by updating the version in requirements.txt. Should we disable the main
test suite for now to unblock the upload of 1.24.0?
Regards,
--Bradford
[0]: https://salsa.debian.org/postgresql/pgbouncer/-/jobs/6962351--Brian Cosgrove--Brian Cosgrove
Brian Cosgrove
Thanks for the heads up, Bradford. https://github.com/pgbouncer/pgbouncer/pull/1250
On Mon, Jan 20, 2025 at 11:55 PM Brian Cosgrove <cosgroveb@gmail.com> wrote:
Ah, funny, we (pgbouncer) just started pinning this in requirements.txt because of this failure: https://github.com/pgbouncer/pgbouncer/commit/0cf59fadc0671a7363afa51086631b87a26893dcOn Mon, Jan 20, 2025 at 11:38 PM Brian Cosgrove <cosgroveb@gmail.com> wrote:I think this note in the psycopg 3.2.4 news is what we're seeing in the pgbouncer tests: https://github.com/psycopg/psycopg/compare/3.2.3...3.2.4#diff-87f7a7bb7fe8dbed76e16b67b87f27bda7b779b56e7d93ed3350d77ee4a3f217R20-R23On Mon, Jan 20, 2025 at 11:25 PM Brian Cosgrove <cosgroveb@gmail.com> wrote:Yes, please do. A Postgres client package (psycopg) update causing failing integration tests seems highly unlikely to be a genuine issue for the pgbouncer.I also reproduced locally the failures you're seeing on Salsa. I notice that there are relevant changes in psycopg 3.2.4 and I think that there are some assertions needing updates in the upstream project.I'll file an issue with pgbouncer but for now please unblock the upload.On Mon, Jan 20, 2025 at 10:42 PM Bradford Boyle <bradford.d.boyle@gmail.com> wrote:Hi Brian,
I was looking at the package for pgBouncer 1.24.0 again today and it
looks like the tests are failing [0]. After reading through the logs, it
looks like psycopg in testing and unstable was updated to 3.2.4 this
past Friday. I am able to reproduce the test failures in dev environment
by updating the version in requirements.txt. Should we disable the main
test suite for now to unblock the upload of 1.24.0?
Regards,
--Bradford
[0]: https://salsa.debian.org/postgresql/pgbouncer/-/jobs/6962351--Brian Cosgrove--Brian Cosgrove--Brian Cosgrove
Brian Cosgrove