Обсуждение: Re: pg_dump, pg_dumpall, pg_restore: Add --no-policies option

Поиск
Список
Период
Сортировка

Re: pg_dump, pg_dumpall, pg_restore: Add --no-policies option

От
Greg Sabino Mullane
Дата:
Looks good to me. Would ideally like to see some tests: should be easy enough to add to t/002_pg_dump.pl, but probably not worth it just for a simple flag like this? We don't test a lot of other flags, but on the other hand, that's what a test suite is supposed to do.

Cheers,
Greg

Re: pg_dump, pg_dumpall, pg_restore: Add --no-policies option

От
jian he
Дата:
hi.

around src/bin/pg_dump/pg_dump.c line 1117
right after "ropt->no_comments = dopt.no_comments;"
we also need add
    ropt->no_policies = dopt.no_policies;
?

overall looks good to me.
The tests seem wrong per
https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F5499
I have no idea how to improve the test.