Обсуждение: pgsql: Fix meson build with -Duuid=ossp when using version older than 0

Поиск
Список
Период
Сортировка

pgsql: Fix meson build with -Duuid=ossp when using version older than 0

От
Michael Paquier
Дата:
Fix meson build with -Duuid=ossp when using version older than 0.60

The package for the UUID library may be named "uuid" or "ossp-uuid", and
meson.build has been using a single call of dependency() with multiple
names, something only supported since meson 0.60.0.

The minimum version of meson supported by Postgres is 0.57.2 on HEAD,
since f039c2244110, and 0.54 on stable branches down to 16.

Author: Oreo Yang <oreo.yang@hotmail.com>
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Discussion: https://postgr.es/m/OS3P301MB01656E6F91539770682B1E77E711A@OS3P301MB0165.JPNP301.PROD.OUTLOOK.COM
Backpatch-through: 16

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5f565b0aee90ef94fbfcfce0beadc10c0ccdd463

Modified Files
--------------
meson.build | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)


Re: pgsql: Fix meson build with -Duuid=ossp when using version older than 0

От
Tom Lane
Дата:
Michael Paquier <michael@paquier.xyz> writes:
> Fix meson build with -Duuid=ossp when using version older than 0.60

Um ... we are in release freeze for 18.0.  Not sure that this
is something that justifies breaking freeze.

            regards, tom lane



Re: pgsql: Fix meson build with -Duuid=ossp when using version older than 0

От
Michael Paquier
Дата:
On Sun, Sep 21, 2025 at 07:49:44PM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
> > Fix meson build with -Duuid=ossp when using version older than 0.60
>
> Um ... we are in release freeze for 18.0.  Not sure that this
> is something that justifies breaking freeze.

Argh.  Sorry about that!  Would you prefer if I revert immediately on
~18?
--
Michael

Вложения

Re: pgsql: Fix meson build with -Duuid=ossp when using version older than 0

От
Tom Lane
Дата:
Michael Paquier <michael@paquier.xyz> writes:
> Argh.  Sorry about that!  Would you prefer if I revert immediately on
> ~18?

Yeah, reverting on 18 and leaving the other branches alone
would be fine with me.  We can put it back in 18 after the
release.

            regards, tom lane



Re: pgsql: Fix meson build with -Duuid=ossp when using version older than 0

От
Michael Paquier
Дата:
On Sun, Sep 21, 2025 at 07:57:05PM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> Argh.  Sorry about that!  Would you prefer if I revert immediately on
>> ~18?
>
> Yeah, reverting on 18 and leaving the other branches alone
> would be fine with me.  We can put it back in 18 after the
> release.

Done now on REL_18_STABLE.  Again, my apologies for the timing
mistake.  That slipped out of my mind.
--
Michael

Вложения

Re: pgsql: Fix meson build with -Duuid=ossp when using version older than 0

От
Tom Lane
Дата:
Michael Paquier <michael@paquier.xyz> writes:
> Done now on REL_18_STABLE.  Again, my apologies for the timing
> mistake.  That slipped out of my mind.

Partly my fault --- I should have sent a reminder to the
committers list, but forgot to.

            regards, tom lane



Re: pgsql: Fix meson build with -Duuid=ossp when using version older than 0

От
Michael Paquier
Дата:
On Sun, Sep 21, 2025 at 08:09:18PM -0400, Tom Lane wrote:
> Partly my fault --- I should have sent a reminder to the
> committers list, but forgot to.

Now that 18.0 has been tagged and that I can get back from the corner,
re-applied as of 178bbf403cc5 on REL_18_STABLE.
--
Michael

Вложения