Обсуждение: pgbench: remove an unused function argument

Поиск
Список
Период
Сортировка

pgbench: remove an unused function argument

От
Yugo Nagata
Дата:
Hi,

I've attached a patch that removes an unused argument from
create_sql_command() in pgbench.c.

This originates from commit 68ab8e8ba4a4, which split process_commands()
into process_sql_command() (the predecessor of create_sql_command())
and process_backslash_command().

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>

Вложения

Re: pgbench: remove an unused function argument

От
Steven Niu
Дата:
Looks good to me.  

Best Regards,
Steven

From: Yugo Nagata <nagata@sraoss.co.jp>
Sent: Wednesday, September 17, 2025 10:28
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: pgbench: remove an unused function argument
 
Hi,

I've attached a patch that removes an unused argument from
create_sql_command() in pgbench.c.

This originates from commit 68ab8e8ba4a4, which split process_commands()
into process_sql_command() (the predecessor of create_sql_command())
and process_backslash_command().

Regards,
Yugo Nagata

--
Yugo Nagata <nagata@sraoss.co.jp>

Re: pgbench: remove an unused function argument

От
Fujii Masao
Дата:
On Wed, Sep 17, 2025 at 5:25 PM Steven Niu <niushiji@gmail.com> wrote:
> I've attached a patch that removes an unused argument from
> create_sql_command() in pgbench.c.

LGTM. Barring any objection, I will commit the patch.

Regards,

--
Fujii Masao



Re: pgbench: remove an unused function argument

От
Fujii Masao
Дата:
On Wed, Sep 17, 2025 at 10:31 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Wed, Sep 17, 2025 at 5:25 PM Steven Niu <niushiji@gmail.com> wrote:
> > I've attached a patch that removes an unused argument from
> > create_sql_command() in pgbench.c.
>
> LGTM. Barring any objection, I will commit the patch.

I've pushed the patch. Thanks!

Regards,

--
Fujii Masao