Обсуждение: CREATE TABLE LIKE(INCLUDING COMMENTS) description ignored STATISTICS
hi. https://www.postgresql.org/docs/devel/sql-createtable.html#SQL-CREATETABLE-PARMS-LIKE-OPT-COMMENTS """ INCLUDING COMMENTS Comments for the copied columns, constraints, and indexes will be copied. The default behavior is to exclude comments, resulting in the copied columns and constraints in the new table having no comments. """ The above description should mention that comments on extended statistics will be copied as well?
Re: CREATE TABLE LIKE(INCLUDING COMMENTS) description ignored STATISTICS
От
"David G. Johnston"
Дата:
On Saturday, September 6, 2025, jian he <jian.universality@gmail.com> wrote:
hi.
https://www.postgresql.org/docs/devel/sql-createtable. html#SQL-CREATETABLE-PARMS- LIKE-OPT-COMMENTS
"""
INCLUDING COMMENTS
Comments for the copied columns, constraints, and indexes will be copied. The
default behavior is to exclude comments, resulting in the copied columns and
constraints in the new table having no comments.
"""
The above description should mention that comments on extended
statistics will be
copied as well?
How about “If specified, existing comments on any copied elements are copied as well.” ? Let’s fix this by removing the duplication of the list of things allowed to be copied, not by fixing the oversight the duplication permitted.
David J.
On Sun, Sep 7, 2025 at 1:03 PM David G. Johnston <david.g.johnston@gmail.com> wrote: > > On Saturday, September 6, 2025, jian he <jian.universality@gmail.com> wrote: >> >> hi. >> >> https://www.postgresql.org/docs/devel/sql-createtable.html#SQL-CREATETABLE-PARMS-LIKE-OPT-COMMENTS >> """ >> INCLUDING COMMENTS >> Comments for the copied columns, constraints, and indexes will be copied. The >> default behavior is to exclude comments, resulting in the copied columns and >> constraints in the new table having no comments. >> """ >> >> The above description should mention that comments on extended >> statistics will be >> copied as well? >> > > How about “If specified, existing comments on any copied elements are copied as well.” ? Let’s fix this by removing theduplication of the list of things allowed to be copied, not by fixing the oversight the duplication permitted. > “If specified, existing comments on any copied elements are copied as well.” some properties/elements don't have comments. currently doc: ------------------------------------------------- The optional like_option clauses specify which additional properties of the original table to copy. Specifying INCLUDING copies the property, specifying EXCLUDING omits the property. EXCLUDING is the default. If multiple specifications are made for the same kind of object, the last one is used. The available options are: INCLUDING COMMENTS Comments for the copied columns, constraints, and indexes will be copied. The default behavior is to exclude comments, resulting in the copied columns and constraints in the new table having no comments. ------------------------------------------------------------------------ The second sentence is redundant, because we already mentioned: "EXCLUDING is the default". So I am ok with: "Comments for the copied columns, constraints, extended statistics and indexes will be copied". the second sentence "The default behavior is to exclude comments...." can be removed. I also found that https://www.postgresql.org/docs/devel/sql-createforeigntable.html has the same problem.