Обсуждение: Fix an unnecessary cast calling elog in ExecHashJoinImpl

Поиск
Список
Период
Сортировка

Fix an unnecessary cast calling elog in ExecHashJoinImpl

От
Tender Wang
Дата:
Hi,

While debugging the HashJoin codes, I noticed below codes in ExecHashJoinImpl():

elog(ERROR, "unrecognized hashjoin state: %d",
(int) node->hj_JoinState);

The type of hj_JoinState is already int, so the cast seems unnecessary.
So I remove it in the attached patch.

--
Thanks,
Tender Wang
Вложения

Re: Fix an unnecessary cast calling elog in ExecHashJoinImpl

От
Chao Li
Дата:


On Aug 30, 2025, at 14:09, Tender Wang <tndrwang@gmail.com> wrote:

Hi,

While debugging the HashJoin codes, I noticed below codes in ExecHashJoinImpl():

elog(ERROR, "unrecognized hashjoin state: %d",
(int) node->hj_JoinState);

The type of hj_JoinState is already int, so the cast seems unnecessary.
So I remove it in the attached patch.

--
Thanks,
Tender Wang
<0001-Fix-an-unnecessary-cast-calling-elog-in-ExecHashJoin.patch>

Yes, hj_JoinState is of type int, so the type cast to int is not needed. The change looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/