Обсуждение: Re: pgsql: oauth: Add unit tests for multiplexer handling

Re: Jacob Champion
> oauth: Add unit tests for multiplexer handling

This seems to require more linking on Debian bullseye:

20:19:29 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute-Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security
-fno-strict-aliasing-fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation
-moutline-atomics-g -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security-fPIC test-oauth-curl.o oauth-utils.o -L../../../src/port -L../../../src/common
-L../../../src/common-lpgcommon_shlib -L../../../src/port -lpgport_shlib -L../../../src/interfaces/libpq -lpq
-Wl,-z,relro-Wl,-z,now  -Wl,--as-needed   -lcurl -lm  -o oauth_tests
 
20:19:29 /usr/bin/ld: oauth-utils.o: undefined reference to symbol 'pthread_sigmask@@GLIBC_2.17'
20:19:29 /usr/bin/ld: /lib/aarch64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
20:19:29 collect2: error: ld returned 1 exit status

Full log:
https://jengus.postgresql.org/job/postgresql-19-binaries-snapshot/architecture=arm64,distribution=bullseye/156/console

Distro releases newer than bullseye are fine.

Christoph

On Tue, Aug 26, 2025 at 12:48 PM Christoph Berg <myon@debian.org> wrote:
> This seems to require more linking on Debian bullseye:

Bleh. Thanks for the report; looks like none of the bullseye animals
in the farm are building with Curl yet.

(cc Stefan: guaibasaurus seems like it'd be a good candidate; would
you consider using --with-libcurl there?)

> 20:19:29 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute-Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security
-fno-strict-aliasing-fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation
-moutline-atomics-g -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security-fPIC test-oauth-curl.o oauth-utils.o -L../../../src/port -L../../../src/common
-L../../../src/common-lpgcommon_shlib -L../../../src/port -lpgport_shlib -L../../../src/interfaces/libpq -lpq
-Wl,-z,relro-Wl,-z,now  -Wl,--as-needed   -lcurl -lm  -o oauth_tests 
> 20:19:29 /usr/bin/ld: oauth-utils.o: undefined reference to symbol 'pthread_sigmask@@GLIBC_2.17'
> 20:19:29 /usr/bin/ld: /lib/aarch64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
> 20:19:29 collect2: error: ld returned 1 exit status

Okay. So I need to pull in PTHREAD_CFLAGS/LIBS as well...

--Jacob

On Tue, Aug 26, 2025 at 1:10 PM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> Okay. So I need to pull in PTHREAD_CFLAGS/LIBS as well...

Christoph, are you able to verify the attached patch fixes the build?

--Jacob

Re: Jacob Champion
> On Tue, Aug 26, 2025 at 1:10 PM Jacob Champion
> <jacob.champion@enterprisedb.com> wrote:
> > Okay. So I need to pull in PTHREAD_CFLAGS/LIBS as well...
> 
> Christoph, are you able to verify the attached patch fixes the build?

The patch fixes the autoconf build here.

Thanks,
Christoph

On Tue, Aug 26, 2025 at 1:45 PM Christoph Berg <myon@debian.org> wrote:
> The patch fixes the autoconf build here.

Thanks! The meson side needs an additional thread_dep as well; once
that passes CI I will push.

--Jacob

On Tue, Aug 26, 2025 at 2:18 PM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> Thanks! The meson side needs an additional thread_dep as well; once
> that passes CI I will push.

Committed and backpatched. Thanks again!

--Jacob

Re: Jacob Champion
> Committed and backpatched. Thanks again!

The apt.pg.o build is already happy again, thanks!

https://jengus.postgresql.org/job/postgresql-19-binaries-snapshot/

Christoph

On 26.08.25 22:10, Jacob Champion wrote:
> On Tue, Aug 26, 2025 at 12:48 PM Christoph Berg <myon@debian.org> wrote:
>> This seems to require more linking on Debian bullseye:
> 
> Bleh. Thanks for the report; looks like none of the bullseye animals
> in the farm are building with Curl yet.
> 
> (cc Stefan: guaibasaurus seems like it'd be a good candidate; would
> you consider using --with-libcurl there?)

done - though gaibasauris is actually on bookworm...

Stefan

On Fri, Aug 29, 2025 at 5:57 AM Stefan Kaltenbrunner
<stefan@kaltenbrunner.cc> wrote:
> done -

Thank you!

> though gaibasauris is actually on bookworm...

Oh, good to know. The system description currently says

    Debian GNU/Linux 11 (bullseye) gcc 10.2.1 x86_64

--Jacob