Обсуждение: Enhance Makefiles to rebuild objects on map file changes

On 2025-Aug-06, Chao Li wrote:

> It looks weird. From
> https://www.postgresql.org/message-id/1CA8625F-AA41-4ED2-B60F-E28AC71F37DC%40highgo.com,
> I don’t see the attachment of the patch file. However, the email in my
> Inbox has the attachment.

Yeah, AppleMail is known to do this.  I don't know if there's a config
toggle you can use to avoid that, or you just have to use something
else.  If there _is_ an AppleMail toggle that you changed for your later
experiemnts, please let us know what it is, so that we can point other
people with this problem to it.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Las navajas y los monos deben estar siempre distantes"   (Germán Poo)

I finally switch to use my Gmail account. With the Gmail account, AppleMail can send attachment successfully.


> -----Original Messages-----
> From: "Álvaro Herrera" <alvherre@kurilemu.de>
> Send time:Wednesday, 06/08/2025 17:41:46
> To: "Chao Li" <lic@highgo.com>
> Cc: pgsql-hackers@lists.postgresql.org
> Subject: Re: Enhance Makefiles to rebuild objects on map file changes
>
> On 2025-Aug-06, Chao Li wrote:
>
> > It looks weird. From
> > https://www.postgresql.org/message-id/1CA8625F-AA41-4ED2-B60F-E28AC71F37DC%40highgo.com,
> > I don’t see the attachment of the patch file. However, the email in my
> > Inbox has the attachment.
>
> Yeah, AppleMail is known to do this.  I don't know if there's a config
> toggle you can use to avoid that, or you just have to use something
> else.  If there _is_ an AppleMail toggle that you changed for your later
> experiemnts, please let us know what it is, so that we can point other
> people with this problem to it.
>
> --
> Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
> "Las navajas y los monos deben estar siempre distantes"   (Germán Poo)

On Wed, Aug  6, 2025 at 11:41:46AM +0200, Álvaro Herrera wrote:
> On 2025-Aug-06, Chao Li wrote:
> 
> > It looks weird. From
> > https://www.postgresql.org/message-id/1CA8625F-AA41-4ED2-B60F-E28AC71F37DC%40highgo.com,
> > I don’t see the attachment of the patch file. However, the email in my
> > Inbox has the attachment.
> 
> Yeah, AppleMail is known to do this.  I don't know if there's a config
> toggle you can use to avoid that, or you just have to use something
> else.  If there _is_ an AppleMail toggle that you changed for your later
> experiemnts, please let us know what it is, so that we can point other
> people with this problem to it.

I found this from June of 2024 with a fix:

    There's a button in the tool bar called 'Include Attachments'. If
    this button is accidentally switched off then the email won't send
    an email with attachments. So I just went to 'View' and 'Edit
    Toolbar' and got rid of this very useless button. Now I have no
    more problems with certain emails not sending with attachments.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.

On Tue, Aug 12, 2025 at 11:58:12AM -0400, Bruce Momjian wrote:
> On Wed, Aug  6, 2025 at 11:41:46AM +0200, Álvaro Herrera wrote:
> > On 2025-Aug-06, Chao Li wrote:
> > 
> > > It looks weird. From
> > > https://www.postgresql.org/message-id/1CA8625F-AA41-4ED2-B60F-E28AC71F37DC%40highgo.com,
> > > I don’t see the attachment of the patch file. However, the email in my
> > > Inbox has the attachment.
> > 
> > Yeah, AppleMail is known to do this.  I don't know if there's a config
> > toggle you can use to avoid that, or you just have to use something
> > else.  If there _is_ an AppleMail toggle that you changed for your later
> > experiemnts, please let us know what it is, so that we can point other
> > people with this problem to it.
> 
> I found this from June of 2024 with a fix:
> 
>     There's a button in the tool bar called 'Include Attachments'. If
>     this button is accidentally switched off then the email won't send
>     an email with attachments. So I just went to 'View' and 'Edit
>     Toolbar' and got rid of this very useless button. Now I have no
>     more problems with certain emails not sending with attachments.

Sorry, URL is:

    https://discussions.apple.com/thread/254969428?sortBy=rank&page=1

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.

On 2025-Aug-19, Chao Li wrote:

> Hi John,
> 
> Let me explain the Makefile patch in this separate thread, as this is generic to all maps.
> 
> Let’s not use gb18030 as an example, instead, using utf8_and_win.
> 
> When any of the win-related map file changes, it suppose to automatically rebuild utf8_and_win.o.
> 
> WITHOUT this patch, after I touch a map file, it doesn’t rebuild the object file:

Hmm.  Yeah, this really looks somewhat bogus as you say.  I wonder
though if we shouldn't have the UCS_to_*.pl scripts generate a bunch of
"mapdeps.mk" files instead, or something like that, given that these
*.map files are themselves generated.

Also, I suspect you should do something about Meson, but I don't know
what that would look like.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
Thou shalt study thy libraries and strive not to reinvent them without
cause, that thy code may be short and readable and thy days pleasant
and productive. (7th Commandment for C Programmers)

On Tue, Aug 19, 2025 at 10:43 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> Also, I suspect you should do something about Meson, but I don't know
> what that would look like.

It seems to work already on Meson:

$ <build>
$ touch src/backend/utils/mb/Unicode/win874_to_utf8.map
$ <build>
building for debug
ninja: Entering directory `build-debug'
[2/2] Linking target src/backend/utils/mb/conversion_procs/utf8_and_win.so

--
John Naylor
Amazon Web Services