Обсуждение: XLogCtl->ckptFullXid is unused

Поиск
Список
Период
Сортировка

XLogCtl->ckptFullXid is unused

От
Nathan Bossart
Дата:
I just noticed $SUBJECT.  This seems to be an oversight in commit 2fc7af5,
which simultaneously combined ckptXidEpoch and ckptXid into ckptFullXid and
removed the only use of that information, i.e., GetNextXidAndEpoch().  Any
objections if I remove it now?

-- 
nathan

Вложения

Re: XLogCtl->ckptFullXid is unused

От
Aleksander Alekseev
Дата:
Hi Nathan,

> I just noticed $SUBJECT.  This seems to be an oversight in commit 2fc7af5,
> which simultaneously combined ckptXidEpoch and ckptXid into ckptFullXid and
> removed the only use of that information, i.e., GetNextXidAndEpoch().  Any
> objections if I remove it now?

Good catch. I don't see any reason why we might want to keep ckptFullXid. Also I checked if there are any references left to this field - there are none.

Re: XLogCtl->ckptFullXid is unused

От
Nathan Bossart
Дата:
On Sat, Jul 12, 2025 at 12:32:31AM +0300, Aleksander Alekseev wrote:
> Good catch. I don't see any reason why we might want to keep ckptFullXid.
> Also I checked if there are any references left to this field - there are
> none.

Thanks, committed.

-- 
nathan