Обсуждение: Re: Improve doc on parallel stream changes for Stream Abort message

On Mon, Jun 23, 2025 at 2:10 PM Anthonin Bonnefoy
<anthonin.bonnefoy@datadoghq.com> wrote:
>
> While adding parsing of logical replication to Wireshark[1], I've
> found the Stream Abort description possibly misleading. Stream Abort
> will have the Abort LSN and TS when parallel streaming is enabled.
> However, the documentation only mentions "This field is available
> since protocol version 4" which could be interpreted (at least, I've
> interpreted it this way) as "this field will always present with
> protocol version 4".
>
> The attached patch adds a "(only present for parallel stream)" mention
> to the Abort LSN and TS documentation, akin to what's done for
> parallel transactions.
>

How about a slightly modified version like: (a) The LSN of the abort
operation, present only when the change stream can be applied in
parallel. This field is available since protocol version 4. (b) Abort
timestamp of the transaction, present only when the change stream can
be applied in parallel. The value is in number of microseconds since
PostgreSQL epoch (2000-01-01). This field is available since protocol
version 4.

--
With Regards,
Amit Kapila.

On Tue, Jun 24, 2025 at 7:26 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> How about a slightly modified version like: (a) The LSN of the abort
> operation, present only when the change stream can be applied in
> parallel. This field is available since protocol version 4. (b) Abort
> timestamp of the transaction, present only when the change stream can
> be applied in parallel. The value is in number of microseconds since
> PostgreSQL epoch (2000-01-01). This field is available since protocol
> version 4.

What about ", present only when streaming is set to parallel"? I think
clarifying the relation between streaming=parallel and the presence of
those fields is the important part.

On Tue, Jun 24, 2025 at 11:58 AM Anthonin Bonnefoy
<anthonin.bonnefoy@datadoghq.com> wrote:
>
> On Tue, Jun 24, 2025 at 7:26 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > How about a slightly modified version like: (a) The LSN of the abort
> > operation, present only when the change stream can be applied in
> > parallel. This field is available since protocol version 4. (b) Abort
> > timestamp of the transaction, present only when the change stream can
> > be applied in parallel. The value is in number of microseconds since
> > PostgreSQL epoch (2000-01-01). This field is available since protocol
> > version 4.
>
> What about ", present only when streaming is set to parallel"? I think
> clarifying the relation between streaming=parallel and the presence of
> those fields is the important part.
>

Works for me. I'll wait till tomorrow morning to see if there are any
further comments, and then push it.

--
With Regards,
Amit Kapila.