Обсуждение: [PATCH] Remove unused #include's in src/backend/utils/adt/*

Поиск
Список
Период
Сортировка

[PATCH] Remove unused #include's in src/backend/utils/adt/*

От
Aleksander Alekseev
Дата:
Hi,

clangd indicates that certain #include's are redundant. Removing them
will speed up the build process a bit.

-- 
Best regards,
Aleksander Alekseev

Вложения

Re: [PATCH] Remove unused #include's in src/backend/utils/adt/*

От
Tom Lane
Дата:
Aleksander Alekseev <aleksander@timescale.com> writes:
> clangd indicates that certain #include's are redundant. Removing them
> will speed up the build process a bit.

The removals of <math.h> bother me a bit; I believe those used
to be necessary on some platforms.  Maybe nowadays everybody is
close enough to POSIX that you can safely extrapolate from what
clangd says on your own machine, but it's not zero-risk.

            regards, tom lane



Re: [PATCH] Remove unused #include's in src/backend/utils/adt/*

От
Peter Eisentraut
Дата:
On 16.06.25 16:20, Aleksander Alekseev wrote:
>> The removals of <math.h> bother me a bit; I believe those used
>> to be necessary on some platforms.  Maybe nowadays everybody is
>> close enough to POSIX that you can safely extrapolate from what
>> clangd says on your own machine, but it's not zero-risk.
> 
> Sounds good to me, let's keep <math.h>.

committed