Обсуждение: Re: tests for pg_stat_progress_copy.tuples_skipped

On 2025/01/10 23:50, jian he wrote:
> hi.
> seems no regress tests for pg_stat_progress_copy.tuples_skipped.
> 
> CopyFrom
> pgstat_progress_update_param(PROGRESS_COPY_TUPLES_SKIPPED,
>                                cstate->num_errors);
> 
> there is coverage for it. but in regress test, we didn't really print
> out this value (cstate->num_errors)
> 
> The attached patch did minor changes on src/test/regress/sql/copy.sql.
> so we can check if pgstat_progress_update_param(PROGRESS_COPY_TUPLES_SKIPPED..)
> is working as intended or not.

Thanks for the patch!

The patch basically looks good to me.
I’ve made some minor cosmetic adjustments — the updated patch is attached.

Unless there are any objections, I'm thinking to commit it.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

On Mon, Mar 3, 2025 at 5:05 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>
> Thanks for the patch!
>
> The patch basically looks good to me.
> I’ve made some minor cosmetic adjustments — the updated patch is attached.
>
> Unless there are any objections, I'm thinking to commit it.
>

I checked it again manually.
It looks good to me.

po 3. 3. 2025 v 10:05 odesílatel Fujii Masao
<masao.fujii@oss.nttdata.com> napsal:
>
>
>
> On 2025/01/10 23:50, jian he wrote:
> > hi.
> > seems no regress tests for pg_stat_progress_copy.tuples_skipped.
> >
> > CopyFrom
> > pgstat_progress_update_param(PROGRESS_COPY_TUPLES_SKIPPED,
> >                                cstate->num_errors);
> >
> > there is coverage for it. but in regress test, we didn't really print
> > out this value (cstate->num_errors)
> >
> > The attached patch did minor changes on src/test/regress/sql/copy.sql.
> > so we can check if pgstat_progress_update_param(PROGRESS_COPY_TUPLES_SKIPPED..)
> > is working as intended or not.
>
> Thanks for the patch!
>
> The patch basically looks good to me.
> I’ve made some minor cosmetic adjustments — the updated patch is attached.
>
> Unless there are any objections, I'm thinking to commit it.

Looks good to me.

> Regards,
>
> --
> Fujii Masao
> Advanced Computing Technology Center
> Research and Development Headquarters
> NTT DATA CORPORATION

On 2025/03/04 17:57, jian he wrote:
> On Mon, Mar 3, 2025 at 5:05 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> Thanks for the patch!
>>
>> The patch basically looks good to me.
>> I’ve made some minor cosmetic adjustments — the updated patch is attached.
>>
>> Unless there are any objections, I'm thinking to commit it.
>>
> 
> I checked it again manually.
> It looks good to me.

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION