Обсуждение: Re: Document How Commit Handles Aborted Transactions

The following review has been posted through the commitfest application:
make installcheck-world:  tested, failed
Implements feature:       tested, failed
Spec compliant:           tested, failed
Documentation:            tested, failed

Summary:
---------
The patch adds documentation to clarify how PostgreSQL handles aborted transactions during the commit process. The
changesare clear and improve the existing documentation.
 

Testing:
--------
1. Manually applied the patch to the latest master branch (commit 4cffc93).
2. Fixed SGML structure issues in `advanced.sgml` and `commit.sgml` by wrapping `<varlistentry>` in `<variablelist>`.
3. Rebuilt the documentation using `make html`.
4. Verified the new sections are present and correctly formatted in the generated HTML.

Feedback:
---------
- The patch was manually applied due to conflicts in `advanced.sgml` and `commit.sgml`.
- Fixed invalid SGML structure by wrapping `<varlistentry>` in `<variablelist>`.
- The documentation is accurate and follows PostgreSQL’s style guidelines.
- No additional issues were found.

Recommendation:
---------------
Ready for committer. No objections.

The new status of this patch is: Ready for Committer

On Thu, 29 May 2025 at 04:32, David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> Recent discussion led me to realize we are also contrary to the SQL Standard here.  v3 updates the Commit reference
pageto reflect this fact.
 
>
> Leaving ready-to-commit.
>
> David J.
>

Hi!
I reviewed your changes and I agree with them.

The only aspect that drew my attention is in the following sentence:

>+ but instead goes into an aborted state. While in this state all commands except
> +    <xref linkend="sql-commit"/> and <xref linkend="sql-rollback"/> are ignored

We can also do ABORT;

Is this worth noting?

-- 
Best regards,
Kirill Reshke

We can also do ABORT;