Обсуждение: Re: Fix a wrong errmsg in AlterRole()

"=?ISO-8859-1?B?Y2NhNTUwNw==?=" <cca5507@qq.com> writes:
> postgres=> alter group g1 drop user r1;
> ERROR:  permission denied to alter role
> DETAIL:  Only roles with the ADMIN option on role "g1" may add members.

> The errmsg is "add members", but we are doing a drop.
> Here is a small patch to fix it.

Hmm.  Seems simpler to just make the errdetail say "... may add or
drop members."

            regards, tom lane

On Wed, Jan 08, 2025 at 10:29:12AM -0500, Tom Lane wrote:
> "=?ISO-8859-1?B?Y2NhNTUwNw==?=" <cca5507@qq.com> writes:
>> postgres=> alter group g1 drop user r1;
>> ERROR:  permission denied to alter role
>> DETAIL:  Only roles with the ADMIN option on role "g1" may add members.
> 
>> The errmsg is "add members", but we are doing a drop.
>> Here is a small patch to fix it.
> 
> Hmm.  Seems simpler to just make the errdetail say "... may add or
> drop members."

+1.  It looks like this goes back to commit ce6b672 (v16).  The error
message was changed in commit de4d456, which is also a v16 change, so
fortunately this has a good chance of back-patching cleanly.

-- 
nathan

On Thu, Jan 09, 2025 at 10:13:11AM +0800, cca5507 wrote:
> I modified the patch according to Tom's suggestion.

LGTM.  I'll plan on committing this shortly.

-- 
nathan

On Thu, Jan 09, 2025 at 12:27:20PM -0600, Nathan Bossart wrote:
> LGTM.  I'll plan on committing this shortly.

Committed.

-- 
nathan