Обсуждение: Re: SQL/JSON json_table plan clause

On 2024-12-17 Tu 10:11 AM, Nikita Malakhov wrote:
> Hi hackers!
>
> This thread is further work continued in [1], where Amit Langote
> suggested starting discussion on the remaining SQL/JSON feature
> 'PLAN clause for JSON_TABLE' anew.
>
> We'd like to help with merging SQL/JSON patches into vanilla,
> and have adapted PLAN clause to recent changes in JSON_TABLE
> function.
>
> While doing this we've found that some tests with the PLAN clause
> were incorrect, along with JSON_TABLE behavior with this clause.
> We've corrected this behavior, but these corrections required reverting
> some removed and heavily refactored code, so we'd be glad for review
> and feedback on this patch.
>
> Also, we've noticed that Oracle set the PLAN clause for JSON_TABLE
> aside for some reason.


I noticed that several months ago, and I was somewhat surprised. I'm not 
sure anyone else has it either. But that doesn't mean we shouldn't have 
it. It's in the standard and seems useful, so I'm very glad to see this 
effort.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

The following review has been posted through the commitfest application:
make installcheck-world:  tested, failed
Implements feature:       tested, failed
Spec compliant:           not tested
Documentation:            not tested

Hi!
Proposed patch tested at Macosx, compiled and build without warnings.
All tests passed without errors.
JSON_TABLE clause PLAN tested, works as intended.

+1 to commit.

Nikita Malakhov писал(а) 2025-02-03 02:43:
> Hi hackers!
> 
> Patch has been rebased onto the current master.
> 
> --
> 
> Regards,
> Nikita Malakhov
> Postgres Professional
> The Russian Postgres Company
> https://postgrespro.ru/
Hi!

Tested on Mac with 'make check', all tests passed OK.

-- 
Best regards,

Vladlen Popolitov.