Обсуждение: [MASSMAIL]pgsql: Add tests for libpq gssencmode and sslmode options
Add tests for libpq gssencmode and sslmode options Test all combinations of gssencmode, sslmode, whether the server supports SSL and/or GSSAPI encryption, and whether they are accepted by pg_hba.conf. This is in preparation for refactoring that code in libpq, and for adding a new option for "direct SSL" connections, which adds another dimension to the logic. If we add even more options in the future, testing all combinations will become unwieldy and we'll need to rethink this, but for now an exhaustive test is nice. Author: Heikki Linnakangas, Matthias van de Meent Reviewed-by: Jacob Champion Discussion: https://www.postgresql.org/message-id/a3af4070-3556-461d-aec8-a8d794f94894@iki.fi Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1169920ff77025550718b90a5cafc6849875f43f Modified Files -------------- .cirrus.tasks.yml | 2 +- src/test/libpq_encryption/Makefile | 25 + src/test/libpq_encryption/README | 31 ++ src/test/libpq_encryption/meson.build | 18 + .../libpq_encryption/t/001_negotiate_encryption.pl | 548 +++++++++++++++++++++ src/test/meson.build | 1 + 6 files changed, 624 insertions(+), 1 deletion(-)
On 08.04.24 01:50, Heikki Linnakangas wrote: > Add tests for libpq gssencmode and sslmode options Why aren't these tests at src/interfaces/libpq/t/nnn_negotiate_encryption.pl ? > Test all combinations of gssencmode, sslmode, whether the server > supports SSL and/or GSSAPI encryption, and whether they are accepted > by pg_hba.conf. This is in preparation for refactoring that code in > libpq, and for adding a new option for "direct SSL" connections, which > adds another dimension to the logic. > > If we add even more options in the future, testing all combinations > will become unwieldy and we'll need to rethink this, but for now an > exhaustive test is nice. > > Author: Heikki Linnakangas, Matthias van de Meent > Reviewed-by: Jacob Champion > Discussion: https://www.postgresql.org/message-id/a3af4070-3556-461d-aec8-a8d794f94894@iki.fi > > Branch > ------ > master > > Details > ------- > https://git.postgresql.org/pg/commitdiff/1169920ff77025550718b90a5cafc6849875f43f > > Modified Files > -------------- > .cirrus.tasks.yml | 2 +- > src/test/libpq_encryption/Makefile | 25 + > src/test/libpq_encryption/README | 31 ++ > src/test/libpq_encryption/meson.build | 18 + > .../libpq_encryption/t/001_negotiate_encryption.pl | 548 +++++++++++++++++++++ > src/test/meson.build | 1 + > 6 files changed, 624 insertions(+), 1 deletion(-) >
On 10/04/2024 17:48, Peter Eisentraut wrote: > On 08.04.24 01:50, Heikki Linnakangas wrote: >> Add tests for libpq gssencmode and sslmode options > > Why aren't these tests at > src/interfaces/libpq/t/nnn_negotiate_encryption.pl ? To be honest, it never occurred to me. It started out as extra tests under src/test/ssl/, and when I decided to move them out to its own module, I didn't think of moving them to src/interfaces/libpq/t/. I will move it, barring any objections or better ideas. -- Heikki Linnakangas Neon (https://neon.tech)