Обсуждение: pgsql: Allow SIGINT to cancel psql database reconnections.

Поиск
Список
Период
Сортировка

pgsql: Allow SIGINT to cancel psql database reconnections.

От
Robert Haas
Дата:
Allow SIGINT to cancel psql database reconnections.

After installing the SIGINT handler in psql, SIGINT can no longer cancel
database reconnections. For instance, if the user starts a reconnection
and then needs to do some form of interaction (ie psql is polling),
there is no way to cancel the reconnection process currently.

Use PQconnectStartParams() in order to insert a cancel_pressed check
into the polling loop.

Tristan Partin, reviewed by Gurjeet Singh, Heikki Linnakangas, Jelte
Fennema-Nio, and me.

Discussion: http://postgr.es/m/D08WWCPVHKHN.3QELIKZJ2D9RZ@neon.tech

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cafe1056558fe07cdc52b95205588fcd80870362

Modified Files
--------------
src/bin/psql/command.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 71 insertions(+), 1 deletion(-)


Re: pgsql: Allow SIGINT to cancel psql database reconnections.

От
Alexander Korotkov
Дата:
On Tue, Apr 2, 2024 at 5:30 PM Robert Haas <rhaas@postgresql.org> wrote:
> Allow SIGINT to cancel psql database reconnections.
>
> After installing the SIGINT handler in psql, SIGINT can no longer cancel
> database reconnections. For instance, if the user starts a reconnection
> and then needs to do some form of interaction (ie psql is polling),
> there is no way to cancel the reconnection process currently.
>
> Use PQconnectStartParams() in order to insert a cancel_pressed check
> into the polling loop.
>
> Tristan Partin, reviewed by Gurjeet Singh, Heikki Linnakangas, Jelte
> Fennema-Nio, and me.
>
> Discussion: http://postgr.es/m/D08WWCPVHKHN.3QELIKZJ2D9RZ@neon.tech

This appears to have missing pgindent.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2024-04-02%2021%3A19%3A02

------
Regards,
Alexander Korotkov



Re: pgsql: Allow SIGINT to cancel psql database reconnections.

От
Robert Haas
Дата:
On Tue, Apr 2, 2024 at 5:40 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> This appears to have missing pgindent.
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2024-04-02%2021%3A19%3A02

Argh, sorry. I think someone else fixed this.

--
Robert Haas
EDB: http://www.enterprisedb.com